http://www.rune-server.org/runescape...combat-pi.html
curiositys:
-fully single threaded
-Client is player? and why the fuck is the player list array not defined.... that could cause errors if another class other than client is defined.
-looping all people to send a projecticle
-handling streams randomly all over source. packets arent even structured bfore -writen to outstream. if u were to write 2 packets at same time syc issuesbcould happen.
-using dclaws = player.usingclaws???? wtf just say spec on or not
-applynpcmeleedamage and apllyplayermeleedamage; theyre separating npcs from players wtf. theire both entitiys and hits should apply same way.
- BIGGRST WTFFFFF. CLIENT.NPCINDEX CLIENT.PLAYERINDEX SO A PLAYPER MAY BE A NPC AND A NPC MAY BE A PLAYER LOL?
-Again lack of structurr. specs were on player class and everything skill related is also
-Fail conventions such as p.WithinDistance. first that method shouldnt even be at player class since it has more use than that second should be named withinDistance. l2write java conventions.
-player equipment is at player class....
the guy added all this to player class and nothing is required:
public double getstr, getatt, getdef;
public double crossbowDamage;
public int[] clawHit = new int[4];
public boolean[] clanWarRule = new boolean[10];
public boolean multiAttacking, rangeEndGFXHeight, playerFletch,
playerIsFletching, playerIsMining, playerIsFiremaking,
playerIsFishing, playerIsCooking;
public boolean below459 = true, defaultWealthTransfer, updateInventory,
oldSpec, stopPlayerSkill, playerStun, stopPlayerPacket, usingClaws;
public boolean playerBFishing, finishedBarbarianTraining, ignoreDefence,
secondFormAutocast, usingArrows, usingOtherRangeWeapons,
usingCross, magicDef, spellSwap, hasBankPin, recoverysSet;
public int rangeEndGFX, boltDamage, teleotherType, playerTradeWealth,
doAmount, woodcuttingTree, stageT, dfsCount, recoilHits,
playerDialogue, clawDelay, previousDamage;
public boolean protectItem = false;
WHOEVER WROTE THAT CODE AND IF SOURCE IS ALSO LIKE LIKE THAT WRITER TOO, should die..... only an idiot wouldnt agree with me and u can see 317 section is full of worshipers on that tutorial. just people who dont even know what theyre doing.
and this a random tut i picked. i can show u many other reasons.