Thread: Need help with my Yell Command

Results 1 to 7 of 7
  1. #1 Need help with my Yell Command 
    Registered Member DivideByZero's Avatar
    Join Date
    Oct 2014
    Posts
    47
    Thanks given
    0
    Thanks received
    1
    Rep Power
    11
    So, I modified my yell command slightly, making it require one of my servers currency's "Dragon Points", to yell. Except if you're a Donator or Staff it costs nothing.

    Everything works as it's supposed to.

    Except for Player yell.

    It removes the 1 Dragon Point, but doesn't send the yell.

    Here's my command.

    Code:
    case "yell":
    				if (!player.isDonator() && !player.isExtremeDonator() && player.getRights() == 0) {
    					if (player.getInventory().containsItem(4278, 1)) { 
                            player.getInventory().deleteItem(4278, 1);
                            message = "";
            				for (int i = 1; i < cmd.length; i++)
            					message += cmd[i] + ((i == cmd.length - 1) ? "" : " ");
            				sendYell(player, Utils.fixChatMessage(message), false);
            				return true;} else {
                    	player.getPackets().sendGameMessage("You need atleast 1 Dragon Point to yell, or upgrade to Donator.");
                    		return true;}}
    					else if (player.isDonator() || player.isExtremeDonator() || player.getRights() > 0) {
    							message = "";
            				for (int i = 1; i < cmd.length; i++)
            					message += cmd[i] + ((i == cmd.length - 1) ? "" : " ");
            				sendYell(player, Utils.fixChatMessage(message), false);
            				return true;
            				}
    Any help will be greatly appreciated.

    Also if you need to see any other codes or classes just ask.
    Reply With Quote  
     

  2. #2  
    Donator


    Join Date
    Jan 2014
    Posts
    1,652
    Thanks given
    428
    Thanks received
    501
    Rep Power
    221
    So, it removes a point but doesn't send the yell...
    In that case, post your sendyell and make sure u use ;;yell message but I assume that's what ur doing.
    Reply With Quote  
     

  3. #3  
    Registered Member DivideByZero's Avatar
    Join Date
    Oct 2014
    Posts
    47
    Thanks given
    0
    Thanks received
    1
    Rep Power
    11
    Yes, it removes the yell like it's supposed to, but does not 'post'/'send' the yell to the chatbox.

    And is this what you mean?
    Code:
    else if (player.getRights() == 0)
    				World.sendWorldMessage("[<col=02ab2f>World</col>]"
    						+ player.getDisplayName() + ": <col=02ab2f>" + message
    						+ "</col>", false);
    Reply With Quote  
     

  4. #4  
    L O S E Y O U R S E L F
    Format's Avatar
    Join Date
    Aug 2013
    Posts
    2,311
    Thanks given
    1,131
    Thanks received
    1,461
    Rep Power
    5000
    Code:
    case "yell":
    				if (!player.isDonator() && !player.isExtremeDonator() && player.getRights() == 0) {
    					if (player.getInventory().containsItem(4278, 1)) { 
                            player.getInventory().deleteItem(4278, 1);
                            message = "";
            				for (int i = 1; i < cmd.length; i++)
            					message += cmd[i] + ((i == cmd.length - 1) ? "" : " ");
            				sendYell(player, Utils.fixChatMessage(message), false);
            				return true;
                             } else if (player.isDonator() || player.isExtremeDonator() || player.getRights() > 0) {
    							message = "";
            				for (int i = 1; i < cmd.length; i++)
            					message += cmd[i] + ((i == cmd.length - 1) ? "" : " ");
            				sendYell(player, Utils.fixChatMessage(message), false);
            				return true;
                                           } else {
                    	player.getPackets().sendGameMessage("You need atleast 1 Dragon Point to yell, or upgrade to Donator.");
                    		return true;
                                   }
                                   return true;
    Try using this, then let me know the outcome.


    Reply With Quote  
     

  5. #5  
    Registered Member
    danimals br0's Avatar
    Join Date
    Aug 2010
    Posts
    885
    Thanks given
    64
    Thanks received
    94
    Rep Power
    109
    case "yell":
    if (player.getRights() == 0) {
    boolean deleted = false;
    if (player.getInventory().containsItem(4278, 1)) {
    player.getInventory().deleteItem(4278, 1);
    deleted = true;
    }
    if (!deleted) {
    player.getPackets().sendGameMessage("You need atleast 1 Dragon Point to yell, or upgrade to Donator.");
    return;
    }
    }
    message = "";

    for (int i = 1; i < cmd.length; i++)
    message += cmd[i] + ((i == cmd.length - 1) ? "" : " ");

    sendYell(player, Utils.fixChatMessage(message), false);
    return true;
    ´
    something like that should do the work.
    Reply With Quote  
     

  6. #6  
    Registered Member DivideByZero's Avatar
    Join Date
    Oct 2014
    Posts
    47
    Thanks given
    0
    Thanks received
    1
    Rep Power
    11
    Quote Originally Posted by Format View Post
    Code:
    case "yell":
    				if (!player.isDonator() && !player.isExtremeDonator() && player.getRights() == 0) {
    					if (player.getInventory().containsItem(4278, 1)) { 
                            player.getInventory().deleteItem(4278, 1);
                            message = "";
            				for (int i = 1; i < cmd.length; i++)
            					message += cmd[i] + ((i == cmd.length - 1) ? "" : " ");
            				sendYell(player, Utils.fixChatMessage(message), false);
            				return true;
                             } else if (player.isDonator() || player.isExtremeDonator() || player.getRights() > 0) {
    							message = "";
            				for (int i = 1; i < cmd.length; i++)
            					message += cmd[i] + ((i == cmd.length - 1) ? "" : " ");
            				sendYell(player, Utils.fixChatMessage(message), false);
            				return true;
                                           } else {
                    	player.getPackets().sendGameMessage("You need atleast 1 Dragon Point to yell, or upgrade to Donator.");
                    		return true;
                                   }
                                   return true;
    Try using this, then let me know the outcome.


    Eclipse is telling me that last "return true;" is unreachable.

    Edit: Doesn't let player yell, and removes dragon points even for donators.

    Quote Originally Posted by danimals br0 View Post
    Code:
    case "yell":
    if (player.getRights() == 0) {
    boolean deleted = false;
    if (player.getInventory().containsItem(4278, 1)) { 
    	player.getInventory().deleteItem(4278, 1);
    	deleted = true;
    }
    if (!deleted) {
    player.getPackets().sendGameMessage("You need atleast 1 Dragon Point to yell, or upgrade to Donator.");
    return;
    }
    }
    message = "";
    
    for (int i = 1; i < cmd.length; i++)
    message += cmd[i] + ((i == cmd.length - 1) ? "" : " ");
    
    sendYell(player, Utils.fixChatMessage(message), false);
    return true;
    ´
    something like that should do the work.

    Didn't work.


    Thank you for your support and help so far, it's very appreciated!
    Reply With Quote  
     

  7. #7  
    Registered Member DivideByZero's Avatar
    Join Date
    Oct 2014
    Posts
    47
    Thanks given
    0
    Thanks received
    1
    Rep Power
    11
    Bump still need help.

    EDIT: Just realized it hasn't been 24 hrs. My bad :\
    Reply With Quote  
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Need help with my yell command..
    By tomstahh in forum Help
    Replies: 15
    Last Post: 09-05-2012, 07:05 PM
  2. need help with my spawn command.
    By pjc9119 in forum Tutorials
    Replies: 9
    Last Post: 09-05-2011, 10:34 PM
  3. Need some help with the 'Yell' command.
    By eiowsjio in forum Help
    Replies: 0
    Last Post: 08-24-2010, 01:37 AM
  4. Need Help With A Yell Command!!!
    By Zivik in forum Help
    Replies: 0
    Last Post: 11-08-2009, 01:54 AM
  5. Need Help With My Command.
    By Boxxy in forum Requests
    Replies: 8
    Last Post: 09-18-2009, 03:45 AM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •