Thread: Cleaning my code, [718 matrix] gear + stat + pray book + mage book spawning + healing

Results 1 to 6 of 6
  1. #1 Cleaning my code, [718 matrix] gear + stat + pray book + mage book spawning + healing 
    Extreme Donator


    Join Date
    Sep 2011
    Posts
    1,034
    Thanks given
    133
    Thanks received
    257
    Rep Power
    76
    Pretty much the title using dialogue to switch gear with some spawned sets, however i feel as if the code isnt clean or could be greatly improved, if anyone has any better suggestions to do this efficently can you please give me the advice as i'd greatly appreciate it

    Code:
    				//Bank items
    				player.getBank().depositAllEquipment(true);
    				player.getBank().depositAllInventory(true);
    				player.getBank().depositAllBob(true);
    				player.sendMessage("Your current inventory + equiped items have being sent to the bank");
    				//Set gear to player
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_CAPE, new Item(2413));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_HAT, new Item(10828));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_CHEST, new Item(4091));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_SHIELD, new Item(3842));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_LEGS, new Item(4093));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_FEET, new Item(3105));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_HANDS, new Item(7462));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_WEAPON, new Item(4675));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_AMULET, new Item(1712));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_RING, new Item(2550));
    				player.getEquipment().refresh(0);
    				player.getEquipment().refresh(1);
    				player.getEquipment().refresh(2);
    				player.getEquipment().refresh(3);
    				player.getEquipment().refresh(4);
    				player.getEquipment().refresh(5);
    				player.getEquipment().refresh(6);
    				player.getEquipment().refresh(7);
    				player.getEquipment().refresh(8);
    				player.getEquipment().refresh(9);
    				player.getEquipment().refresh(10);
    				player.getEquipment().refresh(11);
    				player.getEquipment().refresh(12);
    				player.getEquipment().refresh(13);
    				player.getEquipment().refresh(14);
    				player.getAppearence().generateAppearenceData();
    				//give skills
    				player.getSkills().setXp(0, 13034905);
    				player.getSkills().setXp(1, 13034905);
    				player.getSkills().setXp(2, 13034905);
    				player.getSkills().setXp(3, 13034905);
    				player.getSkills().setXp(4, 13034905);
    				player.getSkills().setXp(5, 13034905);
    				player.getSkills().setXp(6, 13034905);
    				player.getSkills().setXp(23, 13034905);
    
    				//ROW 1
    				player.getInventory().addItem(4587, 1);
    				player.getInventory().addItem(1127, 1);
    				player.getInventory().addItem(2503, 1);
    				player.getInventory().addItem(23255, 1);
    				//ROW 2	
    				player.getInventory().addItem(6524, 1);
    				player.getInventory().addItem(1079, 1);
    				player.getInventory().addItem(5698, 1);
    				player.getInventory().addItem(23279, 1);
    				//ROW 3
    				player.getInventory().addItem(385, 3);
    				player.getInventory().addItem(23399, 1);
    				//ROW 4
    				player.getInventory().addItem(385, 3);
    				player.getInventory().addItem(23399, 1);
    				//ROW 5
    				player.getInventory().addItem(385, 3);
    				player.getInventory().addItem(23351, 1);
    				//ROW 6
    				player.getInventory().addItem(385, 3);
    				player.getInventory().addItem(23351, 1);
    				//ROW 7
    				player.getInventory().addItem(8013, 20);
    				player.getInventory().addItem(555, 5000);
    				player.getInventory().addItem(560, 5000);
    				player.getInventory().addItem(565, 5000);
    				//Pray Book + mage Book + restore spec
    				player.getCombatDefinitions().resetSpecialAttack();
    				player.getCombatDefinitions().setSpellBook(1);
    				player.getPrayer().setPrayerBook(true);
    				//heals + reset stats to correct level
    				player.getPrayer()
    				.restorePrayer(
    				player.getSkills().getLevelForXp(
    				Skills.PRAYER) * 10);
    				if (player.getPoison().isPoisoned())
    				player.getPoison().reset();
    				player.setRunEnergy(100);
    				player.heal(player.getMaxHitpoints());
    				player.getSkills().restoreSkills();
    				player.getAppearence().generateAppearenceData();
    				player.getSkills().set(Skills.SUMMONING,
    				player.getSkills().getLevelForXp(Skills.SUMMONING));
    				player.getSkills().refresh(Skills.SUMMONING);
    				player.getAppearence().generateAppearenceData();
    				end();
    Reply With Quote  
     

  2. #2  
    Contributor

    clem585's Avatar
    Join Date
    Sep 2013
    Posts
    3,788
    Thanks given
    706
    Thanks received
    702
    Rep Power
    570
    Quote Originally Posted by Dan_ View Post
    Pretty much the title using dialogue to switch gear with some spawned sets, however i feel as if the code isnt clean or could be greatly improved, if anyone has any better suggestions to do this efficently can you please give me the advice as i'd greatly appreciate it

    Code:
    				//Bank items
    				player.getBank().depositAllEquipment(true);
    				player.getBank().depositAllInventory(true);
    				player.getBank().depositAllBob(true);
    				player.sendMessage("Your current inventory + equiped items have being sent to the bank");
    				//Set gear to player
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_CAPE, new Item(2413));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_HAT, new Item(10828));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_CHEST, new Item(4091));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_SHIELD, new Item(3842));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_LEGS, new Item(4093));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_FEET, new Item(3105));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_HANDS, new Item(7462));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_WEAPON, new Item(4675));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_AMULET, new Item(1712));
    				player.getEquipment().getItems()
    				.set(Equipment.SLOT_RING, new Item(2550));
    				player.getEquipment().refresh(0);
    				player.getEquipment().refresh(1);
    				player.getEquipment().refresh(2);
    				player.getEquipment().refresh(3);
    				player.getEquipment().refresh(4);
    				player.getEquipment().refresh(5);
    				player.getEquipment().refresh(6);
    				player.getEquipment().refresh(7);
    				player.getEquipment().refresh(8);
    				player.getEquipment().refresh(9);
    				player.getEquipment().refresh(10);
    				player.getEquipment().refresh(11);
    				player.getEquipment().refresh(12);
    				player.getEquipment().refresh(13);
    				player.getEquipment().refresh(14);
    				player.getAppearence().generateAppearenceData();
    				//give skills
    				player.getSkills().setXp(0, 13034905);
    				player.getSkills().setXp(1, 13034905);
    				player.getSkills().setXp(2, 13034905);
    				player.getSkills().setXp(3, 13034905);
    				player.getSkills().setXp(4, 13034905);
    				player.getSkills().setXp(5, 13034905);
    				player.getSkills().setXp(6, 13034905);
    				player.getSkills().setXp(23, 13034905);
    
    				//ROW 1
    				player.getInventory().addItem(4587, 1);
    				player.getInventory().addItem(1127, 1);
    				player.getInventory().addItem(2503, 1);
    				player.getInventory().addItem(23255, 1);
    				//ROW 2	
    				player.getInventory().addItem(6524, 1);
    				player.getInventory().addItem(1079, 1);
    				player.getInventory().addItem(5698, 1);
    				player.getInventory().addItem(23279, 1);
    				//ROW 3
    				player.getInventory().addItem(385, 3);
    				player.getInventory().addItem(23399, 1);
    				//ROW 4
    				player.getInventory().addItem(385, 3);
    				player.getInventory().addItem(23399, 1);
    				//ROW 5
    				player.getInventory().addItem(385, 3);
    				player.getInventory().addItem(23351, 1);
    				//ROW 6
    				player.getInventory().addItem(385, 3);
    				player.getInventory().addItem(23351, 1);
    				//ROW 7
    				player.getInventory().addItem(8013, 20);
    				player.getInventory().addItem(555, 5000);
    				player.getInventory().addItem(560, 5000);
    				player.getInventory().addItem(565, 5000);
    				//Pray Book + mage Book + restore spec
    				player.getCombatDefinitions().resetSpecialAttack();
    				player.getCombatDefinitions().setSpellBook(1);
    				player.getPrayer().setPrayerBook(true);
    				//heals + reset stats to correct level
    				player.getPrayer()
    				.restorePrayer(
    				player.getSkills().getLevelForXp(
    				Skills.PRAYER) * 10);
    				if (player.getPoison().isPoisoned())
    				player.getPoison().reset();
    				player.setRunEnergy(100);
    				player.heal(player.getMaxHitpoints());
    				player.getSkills().restoreSkills();
    				player.getAppearence().generateAppearenceData();
    				player.getSkills().set(Skills.SUMMONING,
    				player.getSkills().getLevelForXp(Skills.SUMMONING));
    				player.getSkills().refresh(Skills.SUMMONING);
    				player.getAppearence().generateAppearenceData();
    				end();
    Something like this:

    Code:
    		    public void idk() {
    		    	//Bank items
    				player.getBank().depositAllEquipment(true);
    				player.getBank().depositAllInventory(true);
    				player.getBank().depositAllBob(true);
    				player.sendMessage("Your current inventory + equiped items have being sent to the bank");
    				//Set gear to player
    				player.getEquipment().getItems().set(Equipment.SLOT_CAPE, new Item(2413));
    				player.getEquipment().getItems().set(Equipment.SLOT_HAT, new Item(10828));
    				player.getEquipment().getItems().set(Equipment.SLOT_CHEST, new Item(4091));
    				player.getEquipment().getItems().set(Equipment.SLOT_SHIELD, new Item(3842));
    				player.getEquipment().getItems().set(Equipment.SLOT_LEGS, new Item(4093));
    				player.getEquipment().getItems().set(Equipment.SLOT_FEET, new Item(3105));
    				player.getEquipment().getItems().set(Equipment.SLOT_HANDS, new Item(7462));
    				player.getEquipment().getItems().set(Equipment.SLOT_WEAPON, new Item(4675));
    				player.getEquipment().getItems().set(Equipment.SLOT_AMULET, new Item(1712));
    				player.getEquipment().getItems().set(Equipment.SLOT_RING, new Item(2550));
    				
    				//refreh equipment + appearence
    				for (int i = 0; i < 15; ++i) {
    					player.getEquipment().refresh(i);
    				}
    				player.getAppearence().generateAppearenceData();
    				
    				//give combat skills
    				for (int i = 0; i < 6; ++i) {
    					player.getSkills().setXp(i, 13034905);
    				}
    				//summoning
    				player.getSkills().setXp(23, 13034905);
    
    				Item[] starterItems = new Item[] { new Item(4587, 1), new Item(1127, 1), new Item(2503, 1), new Item(23255, 1),
    					new Item(6524, 1), new Item(1079, 1), new Item(5698, 1), new Item(23279, 1), new Item(385, 3), new Item(23399, 1),
    					new Item(385, 3), new Item(23399, 1), new Item(385, 3), new Item(23351, 1), new Item(385, 3), new Item(23351, 1),
    					new Item(8013, 1), new Item(555, 5000), new Item(560, 5000), new Item(565, 5000)};
    				
    				for (Item item : starterItems) {
    					player.getInventory().addItem(item.getId(), item.getAmount());
    				}
    				//Pray Book + mage Book + restore spec
    				player.getCombatDefinitions().resetSpecialAttack();
    				player.getCombatDefinitions().setSpellBook(1);
    				player.getPrayer().setPrayerBook(true);
    				
    				//heals + reset stats to correct level
    				player.getPrayer().restorePrayer(player.getSkills().getLevelForXp(Skills.PRAYER) * 10);
    				if (player.getPoison().isPoisoned())
    					player.getPoison().reset();
    				player.setRunEnergy(100);
    				player.heal(player.getMaxHitpoints());
    				player.getSkills().restoreSkills();
    				player.getAppearence().generateAppearenceData();
    				player.getSkills().set(Skills.SUMMONING, player.getSkills().getLevelForXp(Skills.SUMMONING));
    				player.getSkills().refresh(Skills.SUMMONING);
    				player.getAppearence().generateAppearenceData();
    				end();
    		    }
    Project thread
    Reply With Quote  
     

  3. Thankful user:


  4. #3  
    Extreme Donator


    Join Date
    Sep 2011
    Posts
    1,034
    Thanks given
    133
    Thanks received
    257
    Rep Power
    76
    Quote Originally Posted by clem585 View Post
    Something like this:

    Code:
    		    public void idk() {
    		    	//Bank items
    				player.getBank().depositAllEquipment(true);
    				player.getBank().depositAllInventory(true);
    				player.getBank().depositAllBob(true);
    				player.sendMessage("Your current inventory + equiped items have being sent to the bank");
    				//Set gear to player
    				player.getEquipment().getItems().set(Equipment.SLOT_CAPE, new Item(2413));
    				player.getEquipment().getItems().set(Equipment.SLOT_HAT, new Item(10828));
    				player.getEquipment().getItems().set(Equipment.SLOT_CHEST, new Item(4091));
    				player.getEquipment().getItems().set(Equipment.SLOT_SHIELD, new Item(3842));
    				player.getEquipment().getItems().set(Equipment.SLOT_LEGS, new Item(4093));
    				player.getEquipment().getItems().set(Equipment.SLOT_FEET, new Item(3105));
    				player.getEquipment().getItems().set(Equipment.SLOT_HANDS, new Item(7462));
    				player.getEquipment().getItems().set(Equipment.SLOT_WEAPON, new Item(4675));
    				player.getEquipment().getItems().set(Equipment.SLOT_AMULET, new Item(1712));
    				player.getEquipment().getItems().set(Equipment.SLOT_RING, new Item(2550));
    				
    				//refreh equipment + appearence
    				for (int i = 0; i < 15; ++i) {
    					player.getEquipment().refresh(i);
    				}
    				player.getAppearence().generateAppearenceData();
    				
    				//give combat skills
    				for (int i = 0; i < 6; ++i) {
    					player.getSkills().setXp(i, 13034905);
    				}
    				//summoning
    				player.getSkills().setXp(23, 13034905);
    
    				Item[] starterItems = new Item[] { new Item(4587, 1), new Item(1127, 1), new Item(2503, 1), new Item(23255, 1),
    					new Item(6524, 1), new Item(1079, 1), new Item(5698, 1), new Item(23279, 1), new Item(385, 3), new Item(23399, 1),
    					new Item(385, 3), new Item(23399, 1), new Item(385, 3), new Item(23351, 1), new Item(385, 3), new Item(23351, 1),
    					new Item(8013, 1), new Item(555, 5000), new Item(560, 5000), new Item(565, 5000)};
    				
    				for (Item item : starterItems) {
    					player.getInventory().addItem(item.getId(), item.getAmount());
    				}
    				//Pray Book + mage Book + restore spec
    				player.getCombatDefinitions().resetSpecialAttack();
    				player.getCombatDefinitions().setSpellBook(1);
    				player.getPrayer().setPrayerBook(true);
    				
    				//heals + reset stats to correct level
    				player.getPrayer().restorePrayer(player.getSkills().getLevelForXp(Skills.PRAYER) * 10);
    				if (player.getPoison().isPoisoned())
    					player.getPoison().reset();
    				player.setRunEnergy(100);
    				player.heal(player.getMaxHitpoints());
    				player.getSkills().restoreSkills();
    				player.getAppearence().generateAppearenceData();
    				player.getSkills().set(Skills.SUMMONING, player.getSkills().getLevelForXp(Skills.SUMMONING));
    				player.getSkills().refresh(Skills.SUMMONING);
    				player.getAppearence().generateAppearenceData();
    				end();
    		    }
    Thats alot better for me thanks
    Reply With Quote  
     

  5. #4  
    Donator


    Join Date
    Jul 2011
    Posts
    570
    Thanks given
    135
    Thanks received
    142
    Rep Power
    291
    There also might be an easier way to set the equipment. I'm not at home so I won't be able to verify, but if there's an array of items for the equipment, just make an arrad with different items and a method to change the players equipment array for player.getEquipment().getItems().getItems()
    Reply With Quote  
     

  6. #5  
    Success is the worst teacher

    Santa Hat's Avatar
    Join Date
    Oct 2012
    Age
    27
    Posts
    3,334
    Thanks given
    807
    Thanks received
    1,185
    Rep Power
    190
    Quote Originally Posted by clem585 View Post
    Something like this:

    Code:
    		    public void idk() {
    		    	//Bank items
    				player.getBank().depositAllEquipment(true);
    				player.getBank().depositAllInventory(true);
    				player.getBank().depositAllBob(true);
    				player.sendMessage("Your current inventory + equiped items have being sent to the bank");
    				//Set gear to player
    				player.getEquipment().getItems().set(Equipment.SLOT_CAPE, new Item(2413));
    				player.getEquipment().getItems().set(Equipment.SLOT_HAT, new Item(10828));
    				player.getEquipment().getItems().set(Equipment.SLOT_CHEST, new Item(4091));
    				player.getEquipment().getItems().set(Equipment.SLOT_SHIELD, new Item(3842));
    				player.getEquipment().getItems().set(Equipment.SLOT_LEGS, new Item(4093));
    				player.getEquipment().getItems().set(Equipment.SLOT_FEET, new Item(3105));
    				player.getEquipment().getItems().set(Equipment.SLOT_HANDS, new Item(7462));
    				player.getEquipment().getItems().set(Equipment.SLOT_WEAPON, new Item(4675));
    				player.getEquipment().getItems().set(Equipment.SLOT_AMULET, new Item(1712));
    				player.getEquipment().getItems().set(Equipment.SLOT_RING, new Item(2550));
    				
    				//refreh equipment + appearence
    				for (int i = 0; i < 15; ++i) {
    					player.getEquipment().refresh(i);
    				}
    				player.getAppearence().generateAppearenceData();
    				
    				//give combat skills
    				for (int i = 0; i < 6; ++i) {
    					player.getSkills().setXp(i, 13034905);
    				}
    				//summoning
    				player.getSkills().setXp(23, 13034905);
    
    				Item[] starterItems = new Item[] { new Item(4587, 1), new Item(1127, 1), new Item(2503, 1), new Item(23255, 1),
    					new Item(6524, 1), new Item(1079, 1), new Item(5698, 1), new Item(23279, 1), new Item(385, 3), new Item(23399, 1),
    					new Item(385, 3), new Item(23399, 1), new Item(385, 3), new Item(23351, 1), new Item(385, 3), new Item(23351, 1),
    					new Item(8013, 1), new Item(555, 5000), new Item(560, 5000), new Item(565, 5000)};
    				
    				for (Item item : starterItems) {
    					player.getInventory().addItem(item.getId(), item.getAmount());
    				}
    				//Pray Book + mage Book + restore spec
    				player.getCombatDefinitions().resetSpecialAttack();
    				player.getCombatDefinitions().setSpellBook(1);
    				player.getPrayer().setPrayerBook(true);
    				
    				//heals + reset stats to correct level
    				player.getPrayer().restorePrayer(player.getSkills().getLevelForXp(Skills.PRAYER) * 10);
    				if (player.getPoison().isPoisoned())
    					player.getPoison().reset();
    				player.setRunEnergy(100);
    				player.heal(player.getMaxHitpoints());
    				player.getSkills().restoreSkills();
    				player.getAppearence().generateAppearenceData();
    				player.getSkills().set(Skills.SUMMONING, player.getSkills().getLevelForXp(Skills.SUMMONING));
    				player.getSkills().refresh(Skills.SUMMONING);
    				player.getAppearence().generateAppearenceData();
    				end();
    		    }
    a lil follow up

    Code:
    		int[][] items = { { Equipment.SLOT_CAPE, 2413 } };
    		
    		for (int i = 0; i < items.length; i++) 
    		    player.getEquipment().getItems().set(items[i][0], new Item(items[i][1]));


    Reply With Quote  
     

  7. #6  
    Extreme Donator


    Join Date
    Sep 2011
    Posts
    1,034
    Thanks given
    133
    Thanks received
    257
    Rep Power
    76
    Quote Originally Posted by Santa Hat View Post
    a lil follow up

    Code:
    		int[][] items = { { Equipment.SLOT_CAPE, 2413 } };
    		
    		for (int i = 0; i < items.length; i++) 
    		    player.getEquipment().getItems().set(items[i][0], new Item(items[i][1]));
    ah thats great, thanks for the advice will use as well
    Reply With Quote  
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Help with a code, 718 matrix
    By Kexon in forum Help
    Replies: 0
    Last Post: 08-11-2015, 11:58 PM
  2. Need help with coding my 718 Matrix
    By kleinekevermans in forum Requests
    Replies: 4
    Last Post: 10-20-2013, 08:16 PM
  3. Need a developer for my 718 matrix server
    By armadylpkz in forum Advertise
    Replies: 11
    Last Post: 04-25-2013, 05:16 PM
  4. Replies: 6
    Last Post: 03-31-2013, 03:41 AM
  5. Replies: 1
    Last Post: 01-27-2013, 11:56 PM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •