Thread: Help with a command!

Results 1 to 4 of 4
  1. #1 Help with a command! 
    Donator

    Join Date
    Jul 2015
    Posts
    173
    Thanks given
    15
    Thanks received
    15
    Rep Power
    31
    Code:
    if (cmd[0].equalsIgnoreCase("special")) {
    		  for (Player rewards : World.getPlayers()) {
    			  if (cmd[1].equals("key")) {
    				rewards.getBank().addItem(989, Integer.valueOf(cmd[2]));
    				rewards.getBank().addItem(6759, Integer.valueOf(cmd[2]));
    				player.yell("<col=ff0000>[Special]</col> Everyone has been given <col=ff0000>"+Integer.valueOf(cmd[2])+"</col> Enchanted Keys & Chests!");
    			  } else if (cmd[1].equals("coins")) {
    				  rewards.getBank().addItem(995, Integer.valueOf(cmd[2]));
    				 player.yell("<col=ff0000>[Special]</col> Everyone has been given <col=ff0000>"+Integer.valueOf(cmd[2])+"</col> Coins!");  
    			  } else if (cmd[1].equals("redeems")) {
    				  rewards.getBank().addItem(4278, Integer.valueOf(cmd[2]));
    				 player.yell("<col=ff0000>[Special]</col> Everyone has been given <col=ff0000>"+Integer.valueOf(cmd[2])+"</col> Redeems!");
    			  } else if (cmd[1].equals("casket")) {
    				  rewards.getBank().addItem(405, Integer.valueOf(cmd[2]));
    				  player.yell("<col=ff0000>[Special]</col> Everyone has been given <col=ff0000>"+Integer.valueOf(cmd[2])+"</col> Caskets!");
    			  }
    		  }
    		}
    What can I change to stop it from sending the yell for the amount of people online.

    EG - 20 people online = 20 yells sent.
    Reply With Quote  
     

  2. #2  
    Contributor

    clem585's Avatar
    Join Date
    Sep 2013
    Posts
    3,788
    Thanks given
    706
    Thanks received
    702
    Rep Power
    570
    Quote Originally Posted by Optical View Post
    Code:
    if (cmd[0].equalsIgnoreCase("special")) {
    		  for (Player rewards : World.getPlayers()) {
    			  if (cmd[1].equals("key")) {
    				rewards.getBank().addItem(989, Integer.valueOf(cmd[2]));
    				rewards.getBank().addItem(6759, Integer.valueOf(cmd[2]));
    				player.yell("<col=ff0000>[Special]</col> Everyone has been given <col=ff0000>"+Integer.valueOf(cmd[2])+"</col> Enchanted Keys & Chests!");
    			  } else if (cmd[1].equals("coins")) {
    				  rewards.getBank().addItem(995, Integer.valueOf(cmd[2]));
    				 player.yell("<col=ff0000>[Special]</col> Everyone has been given <col=ff0000>"+Integer.valueOf(cmd[2])+"</col> Coins!");  
    			  } else if (cmd[1].equals("redeems")) {
    				  rewards.getBank().addItem(4278, Integer.valueOf(cmd[2]));
    				 player.yell("<col=ff0000>[Special]</col> Everyone has been given <col=ff0000>"+Integer.valueOf(cmd[2])+"</col> Redeems!");
    			  } else if (cmd[1].equals("casket")) {
    				  rewards.getBank().addItem(405, Integer.valueOf(cmd[2]));
    				  player.yell("<col=ff0000>[Special]</col> Everyone has been given <col=ff0000>"+Integer.valueOf(cmd[2])+"</col> Caskets!");
    			  }
    		  }
    		}
    What can I change to stop it from sending the yell for the amount of people online.

    EG - 20 people online = 20 yells sent.
    You'll have to seperate the code in two. Leave the "addItem" part inside the for () loop and put another set of if/else after it with the world messages.
    Project thread
    Reply With Quote  
     

  3. #3  
    Donator

    Join Date
    Jul 2015
    Posts
    173
    Thanks given
    15
    Thanks received
    15
    Rep Power
    31
    Quote Originally Posted by clem585 View Post
    You'll have to seperate the code in two. Leave the "addItem" part inside the for () loop and put another set of if/else after it with the world messages.
    ty sir =)
    Reply With Quote  
     

  4. #4  
    Sexy User
    User's Avatar
    Join Date
    Apr 2013
    Posts
    601
    Thanks given
    97
    Thanks received
    218
    Rep Power
    346
    You could do it like this

    Code:
    if (cmd[0].equalsIgnoreCase("special")) {
                String message = "<col=ff0000>[Special]</col> Everyone has been given <col=ff0000>";
                int amount = Optional.of(Integer.valueOf(cmd[2])).orElse(1);
                List<Item> items = new ArrayList<>();//java.util.List;, java.util.ArrayList;
                switch (cmd[1].toLowerCase()) {
                case "key":
                    items.add(new Item(989, amount));
                    items.add(new Item(6759, amount));
                    message.concat(amount + "</col> Enchanted Key's & Chests!");
                    break;
                case "coins":
                    items.add(new Item(995, amount));
                    message.concat(amount + "</col> Coins!");
                    break;
                case "redeems":
                    items.add(new Item(4278, amount));
                    message.concat(amount + "</col> Redeems!");
                    break;
                case "casket":
                    items.add(new Item(405, amount));
                    message.concat(amount + "</col> Caskets!");
                    break;
                }
                for (Player p : World.getPlayers()) {
                    for (Iterator<Item> it = items.iterator(); it.hasNext();) {
                        Item item = it.next();
                        p.getBank().addItem(item.getId(), item.getAmount());//could just add the (item)
                    }
                }
                player.yell(message);
            }
    Attached image
    Reply With Quote  
     


Thread Information
Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)


User Tag List

Similar Threads

  1. Help With Master Command.
    By pkerz noob in forum Help
    Replies: 5
    Last Post: 02-15-2009, 10:35 AM
  2. Need help with clientside commands
    By Colby in forum Help
    Replies: 5
    Last Post: 01-26-2009, 05:08 AM
  3. Need help with a command..
    By W x 3 in forum Help
    Replies: 10
    Last Post: 10-27-2008, 08:35 PM
  4. Help With "Run (Command Runner)"
    By Tnt Pk in forum Software
    Replies: 2
    Last Post: 05-22-2008, 10:42 PM
  5. [REQ] Help with a Command Prompt...
    By Cky Poons in forum Chat
    Replies: 2
    Last Post: 03-24-2008, 07:08 AM
Posting Permissions
  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •